Define ICACHE_RAM_ATTR for ESP32 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ESP32 support sounds cool! Can you confirm that this library (with this patch) works on an ESP32? |
|
I can confirm that the lib works well (for what I know) on ESP32 :) |
|
Please tell more details, how did you tested it. |
|
This has been released in version 0.12.0. Please report on tests in #23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICACHE_RAM_ATTR is not defined on ESP32 and prevent compiling on this platform.
Defining it to IRAM_ATTR resolves the problem.